Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the embedded_hal_async::delay::DelayUs trait #752

Closed
1 of 3 tasks
jessebraham opened this issue Aug 23, 2023 · 3 comments
Closed
1 of 3 tasks

Implement the embedded_hal_async::delay::DelayUs trait #752

jessebraham opened this issue Aug 23, 2023 · 3 comments

Comments

@jessebraham
Copy link
Member

jessebraham commented Aug 23, 2023

This trait as added in one of the alpha releases, and we never implemented it. This trait will need to be implemented in order to use future versions of embassy.

@MabezDev
Copy link
Member

This trait has been around since the 0.1 release of the eha, but didn't really need to implement it as embassy-time offers an impl based on the time driver impls. If we were to implement this we should impl on the following

  • Systimer (alarms only)
  • TIMG timers
  • Xtensa internal CPU timers (maybe)
  • Anything else that has a configurable time period + interrupt? Maybe something in the RTC domain

@jessebraham
Copy link
Member Author

jessebraham commented Feb 15, 2024

Once #1063 is resolved we can revisit this issue.

@jessebraham jessebraham added the status:blocked Unable to progress - dependent on another task label Feb 15, 2024
@jessebraham jessebraham removed the status:blocked Unable to progress - dependent on another task label Apr 3, 2024
@jessebraham
Copy link
Member Author

This trait is implemented for SYSTIMER directly, and is additionally implemented for OneShotTimer; since the timer::timg module still does not contain an asynch module of its own, I'm just going to close this as "completed".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants