Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build optimization flags should use CONFIG_COMPILER_OPTIMIZATION_* instead of CMAKE_BUILD_TYPE #162

Open
georgik opened this issue Oct 23, 2023 · 1 comment
Open

Build optimization flags should use CONFIG_COMPILER_OPTIMIZATION_* instead of CMAKE_BUILD_TYPE #162

georgik opened this issue Oct 23, 2023 · 1 comment

Comments

@georgik
Copy link

georgik commented Oct 23, 2023

Motivations

Current version of template is using CMAKE_BUILD_TYPE to determine Release/Debug build. Which will result in the command like this:

idf.py -DCMAKE_BUILD_TYPE=Debug build flash monitor

The template should use CONFIG_COMPILER_OPTIMIZATION_DEBUG, CONFIG_COMPILER_OPTIMIZATION_SIZE, CONFIG_COMPILER_OPTIMIZATION_PERF and so on.

Setting CMAKE_BUILD_TYPE in IDF is not a supported way of changing optimization level, more details: espressif/esp-idf#4189
@ivmarkov
Copy link
Collaborator

@georgik Would you mind opening a PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
esp-rs
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@georgik @ivmarkov @tomassebestik