Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument parsing for multiple features is broken #161

Closed
svenstaro opened this issue Apr 25, 2022 · 3 comments · Fixed by #162
Closed

Argument parsing for multiple features is broken #161

svenstaro opened this issue Apr 25, 2022 · 3 comments · Fixed by #162

Comments

@svenstaro
Copy link
Contributor

The arguments are currently parsed incorrectly when multiple comma-separated features are provided such as in --features hello,hola. It gets put into the cargo command like this: --features hello hola.

@jessebraham
Copy link
Member

I believe that is still valid, no? From running cargo build --help it displays:

--features <FEATURES>       Space or comma separated list of features to activate

Which indicates that spaces or commas are accepted.

@svenstaro
Copy link
Contributor Author

But space separated the way they are currently produced will end up as non-feature arguments. You can try it yourself and it will pop out as incorrect if you provide something like --features a,b.

@jessebraham
Copy link
Member

Ahh okay, thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants