Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

espflash monitor without "connecting"? #346

Closed
MabezDev opened this issue Jan 17, 2023 · 1 comment · Fixed by #561
Closed

espflash monitor without "connecting"? #346

MabezDev opened this issue Jan 17, 2023 · 1 comment · Fixed by #561
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@MabezDev
Copy link
Member

Example: I have a debugger session running but I want to view UART output. Right now running the monitor subcommand will reset the chip to detect what it is. It will also load the stub, which seems unnecessary for the monitor subcommand.

Perhaps it should be possible to optionally pass the chip via the CLI, if it's passed then espflash won't try and autodetect the chip and instead just go straight to monitoring.

@MabezDev MabezDev added the enhancement New feature or request label Jan 17, 2023
@jessebraham
Copy link
Member

jessebraham commented Jan 19, 2023

Looking at the monitor implementation I'm not sure we even need to pass the chip? Seems to be agnostic in that regard, unless I'm missing something.

I agree the stub isn't really necessary for the monitor so that could easily be disabled I'm sure. This shouldn't require too many changes I don't think, I'll look into it soon.

Edit: sorry, forgot about the frequency fix for the C2. Maybe Chip is required as a parameter, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants