Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

espflash fails to enable terminal cursor when exited with ctrl-c #365

Closed
faern opened this issue Mar 8, 2023 · 2 comments · Fixed by #372
Closed

espflash fails to enable terminal cursor when exited with ctrl-c #365

faern opened this issue Mar 8, 2023 · 2 comments · Fixed by #372
Assignees
@jessebraham
Labels
bug Something isn't working

Comments

@faern
Copy link

faern commented Mar 8, 2023

If I terminate espflash while in the port selection state my terminal cursor remains disabled. I guess this is because espflash uses terminal raw mode to disable the cursor, and then don't catch and handle the SIGINT signal and enables the cursor before exiting?
@github-project-automation github-project-automation bot moved this to Todo in esp-rs Mar 9, 2023
@jessebraham jessebraham self-assigned this Mar 24, 2023
@jessebraham jessebraham added the bug Something isn't working label Mar 24, 2023
@jessebraham jessebraham mentioned this issue Mar 24, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Mar 24, 2023
@jessebraham
Copy link
Member

Sorry I just realized I closed this issue without saying anything 😅 I've added a fix for this issue which will be available in 2.0.0-rc.4, which we're hoping to publish in the next week or two.

@faern
Copy link
Author

faern commented Mar 29, 2023

Awesome! Thanks 😊 looking forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessebraham jessebraham

Labels
bug Something isn't working
Projects
esp-rs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore the cursor when exiting from serial port selection via Ctrl-C jessebraham/espflash
2 participants
@faern @jessebraham