Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ESP32-C2/H2 do not support 40MHz flash frequency, which is the default, resulting in poor UX #380

Closed
jessebraham opened this issue Mar 31, 2023 · 3 comments · Fixed by #389
Closed

The ESP32-C2/H2 do not support 40MHz flash frequency, which is the default, resulting in poor UX #380

jessebraham opened this issue Mar 31, 2023 · 3 comments · Fixed by #389
Assignees
@SergioGasquez
Labels
enhancement New feature or request

Comments

@jessebraham
Copy link
Member

Some potential solutions were suggested in #375:

  1. Override in main (not so beautiful, but really simple)
  2. Make default method, that accepts Chip (kinda duplicate functionality with Default trait, might be confusing)
  3. Add flash frequency to Esp32Params struct (IMHO this looks the best, but this is too complex for this PR, it might be that size should also be moved)
@jessebraham jessebraham added the enhancement New feature or request label Mar 31, 2023
@SergioGasquez
Copy link
Member

Same happens for ESP32-H2, 40MHz is not a supported flash frequency

@farbodpm
Copy link

May be I can help? Any body can guide me to do this enhancement ?

@SergioGasquez SergioGasquez changed the title The ESP32-C2 does not support 40MHz flash frequency, which is the default, resulting in poor UX The ESP32-C2/H" do not support 40MHz flash frequency, which is the default, resulting in poor UX Apr 17, 2023
@SergioGasquez SergioGasquez changed the title The ESP32-C2/H" do not support 40MHz flash frequency, which is the default, resulting in poor UX The ESP32-C2/H2 do not support 40MHz flash frequency, which is the default, resulting in poor UX Apr 17, 2023
@SergioGasquez SergioGasquez self-assigned this Apr 17, 2023
@SergioGasquez SergioGasquez linked a pull request Apr 17, 2023 that will close this issue
Make the default flashing frequency target specific #389
Merged
@SergioGasquez
Copy link
Member

May be I can help? Any body can guide me to do this enhancement ?

Hi! I started working on this late last Friday and forgot to assign it to me, sorry. I've just created #389 implementing the third suggested solution, feel free to have a look at it and suggest any feedback and, thanks for your help!

@SergioGasquez SergioGasquez moved this from Todo to In Progress in esp-rs Apr 18, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in esp-rs Apr 18, 2023
@SergioGasquez SergioGasquez mentioned this issue Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergioGasquez SergioGasquez

Labels
enhancement New feature or request
Projects
esp-rs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the default flashing frequency target specific SergioGasquez/espflash
3 participants
@jessebraham @SergioGasquez @farbodpm