Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach Servo with controlled stop of waveform #7138

Closed
obrain17 opened this issue Mar 6, 2020 · 1 comment
Closed

Detach Servo with controlled stop of waveform #7138

obrain17 opened this issue Mar 6, 2020 · 1 comment

Comments

@obrain17
Copy link

obrain17 commented Mar 6, 2020

The current code from master detaches a servo within a running PWM duty cycle. This can lead to twitches and in worst case destroy the servo.

There are already comments and PRs for solving this issue. #7084 and #7023
This issue is opened to follow up with this PRs.

@Tech-TX
Copy link
Contributor

Tech-TX commented Mar 23, 2021

This was corrected with #7022 and #7231. A quick test with 2 servos shows that it always stops at the last position before the servo.detach(), and never hits the stops. I attached, swept and detached the servos 40-50 times, no wild sweeps to the stops at detach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants