Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds final fixes for workflows to preview PRs.
As can be seen below, the code has been thoroughly tested, so I will merge it without reviews.
Related
Testing
Testing was done in this PR in a fork.
Among other tests, attempts were made to expose the secrets:
The attempts were unsuccessful, which corroborates the idea that it should be reasonably safe to have workflows for fork PRs that require access to secrets if such workflows use the events:
pull_request
for checking out and building potentially unsafe code from fork PRworkflow_run
for tasks that require access to repository secrets, such as deploying previews to an S3 bucketFor details, see Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests
Checklist
Before submitting a Pull Request, please ensure the following: