Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing Monitor before flashing (VSC-579) #329

Closed
seulater opened this issue Feb 24, 2021 · 4 comments · Fixed by #337 or #358
Closed

Closing Monitor before flashing (VSC-579) #329

seulater opened this issue Feb 24, 2021 · 4 comments · Fixed by #337 or #358

Comments

@seulater
Copy link

If you open the monitor, build your project, then close the monitor, and try to flash you will get a "ESP-IDF Monitor closed" popup.
The only way to recover is to close VSC and reopen it to flash again.

Also, if you already have the monitor open, and try to flash it does close the monitor automatically now, but it cannot then flash. I think you need a bit of a delay from the close to when you actually try to flash.

@github-actions github-actions bot changed the title Closing Monitor before flashing Closing Monitor before flashing (VSC-579) Feb 24, 2021
@brianignacio5
Copy link
Collaborator

brianignacio5 commented Mar 1, 2021

Thanks @seulater for reporting ! PTAL #337

@seulater
Copy link
Author

Just letting you know that this problem is still here. on v 1.0.1
Did you guys actually connect a board and try it?

@brianignacio5
Copy link
Collaborator

Yes @seulater we did tested, actually was hoping you try #337 to see if this still happens. Another user tested and it seemed ok. I'll add a PR .

@seulater
Copy link
Author

OK, To be honest I don't know how to pull in these fixes. I just wait until VSC updates your extension.
If you feel the need, i can take a video of what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants