Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report]: Project relative paths in terminal not resolved on Ctrl+Click (VSC-581) #333

Closed
boarchuz opened this issue Feb 26, 2021 · 2 comments · Fixed by #337
Closed
Labels
bug-report Bug Report from users on Github (don't use this tag manually, its supposed to be used via the issue)

Comments

@boarchuz
Copy link
Contributor

Describe the bug
Version 1.0.0
Ctrl+Click on a relative path in build output in the terminal window results in a VS Code popup indicating that the file could not be found.
eg.
Terminal:

../main/hello_world.c: In function 'app_main':
../main/hello_world.c:28:5: error: 'qwerty' undeclared (first use in this function); did you mean 'qsort'?
     qwerty;
     ^~~~~~

VS Code popup upon Ctrl+Click on any relative path (eg. "../main/hello_world.c:28:5"):

../main/hello_world.c:28:5
No matching results

Absolute paths work correctly. This only affects relative paths.

More info
This was working in 0.5.1.
git bisect:
7abc858 is the first bad commit

@boarchuz boarchuz added the bug-report Bug Report from users on Github (don't use this tag manually, its supposed to be used via the issue) label Feb 26, 2021
@github-actions github-actions bot changed the title [Bug Report]: Project relative paths in terminal not resolved on Ctrl+Click [Bug Report]: Project relative paths in terminal not resolved on Ctrl+Click (VSC-581) Feb 26, 2021
@brianignacio5
Copy link
Collaborator

Thanks for reporting this @boarchuz . I roll back to shellExecution since the original problem is gone. PTAL #337

@boarchuz
Copy link
Contributor Author

boarchuz commented Mar 1, 2021

Thanks, @brianignacio5 , that's fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Bug Report from users on Github (don't use this tag manually, its supposed to be used via the issue)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants