-
Notifications
You must be signed in to change notification settings - Fork 851
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(ngTableSettings): nested options never undefined
This is part of supporting typescript strictNullChecks compiler option BREAKING CHANGES `ISettings`: replaced with `Settings` class and a type alias of `SettingsPartial` `Settings.interceptors`, `Settings.counts`: arrays are cloned therefore any changes to the array will not be recognised `settings(newSettings)`: any setting value supplied as undefined will now be ignored. Instead of `undefined` you will need to supply a suitable value as described below: * `counts` - an empty array to prevent the page size buttons rendering * `filterOptions.filterDelay` - `0` to remove the debounce delay * `filterOptions.filterDelayThreshold` - `null` so that a `dataset` of any size will have a `filterDelay` applied * `groupOptions.sortDirection` - `''` so that grouped columns are NOT sorted by default * `groupOptions.isExpanded` - `false` so that each grouped set of rows are collapsed by default * `paginationMaxBlocks`, `paginationMinBlocks` - `0`
- Loading branch information
1 parent
5317463
commit 6e810ba
Showing
29 changed files
with
783 additions
and
424 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.