Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with go version in go mod #572

Closed
nekohasekai opened this issue Oct 8, 2023 · 1 comment
Closed

Problems with go version in go mod #572

nekohasekai opened this issue Oct 8, 2023 · 1 comment

Comments

@nekohasekai
Copy link

nekohasekai commented Oct 8, 2023

Since go 1.21, if you set go version in go mod to 1.21 or above, all projects that depend on this must also use that version or above, and cannot compile on old go.

I found that the 18ebb97 commit simply promoted the go version without using the features that depended on go 1.21 (I didn't double check, but unsafe.Slice exists in go 1.18 and everything compiles.). If you could consider lowering this configuration to 1.20, it would be more friendly to projects that rely on this library.

@nekohasekai nekohasekai closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2023
@nekohasekai nekohasekai reopened this Oct 8, 2023
@jmhbnz
Copy link
Member

jmhbnz commented Oct 8, 2023

Hi @nekohasekai - Thanks for raising this question. The bbolt project generally follows the same golang version policy as etcd: https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/dependency_management.md#golang-versions

The etcd project aims to maintain a development branch that is on the latest Go version, ideally this will align with the Go version in use for Kubernetes project development.

If you need a version of the bbolt library that is using an older golang release please use the latest tagged release 1.3.7 which uses go 1.17 in go.mod: https://github.com/etcd-io/bbolt/releases/tag/v1.3.7

You can review plans for the 1.3.8 and 1.4.0 releases here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants