Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate cluster attributes to use v3 backend #11380

Closed
4 tasks done
jingyih opened this issue Nov 22, 2019 · 4 comments
Closed
4 tasks done

Migrate cluster attributes to use v3 backend #11380

jingyih opened this issue Nov 22, 2019 · 4 comments

Comments

@jingyih
Copy link
Contributor

jingyih commented Nov 22, 2019

Prerequisite for #9232.

Currently cluster related information still relies on v2store. They need to be migrated to use v3 backend. For example, during restart, member reads cluster attributes (such as cluster version) from the V2 store, which could be very stale. This is because the V2 store recovers from the last snapshot point.

This is probably also needed by #11362. As during downgrade, member restarts with a lower version binary. During restart process, it first checks if its binary version is compatible with cluster version. Because the cluster version info could be very stale and therefore the check might fail. This could cause user confusion.

Task list

- [ ] use proto for cluster attributes (membership, cluster version, etc) - optional (need to decide), this is for better compatibility if we change cluster struct later

  • create v3 server internal raft type for changes to any cluster attribute other than members (cluster version, member attributes, etc).
  • deprecate internal v2 API calls for cluster attributes, instead use v3 requests. (They will not be re-applied if older than current state in v3 backend.)
  • during apply, store cluster attributes to v3 backend.
  • during restart, recover cluster attributes from v3 backend instead of from v2 store.

- [ ] make sure this is compatible with existing raft node restart process.
- [ ] make sure this is compatible with existing snapshot restore process.

@jingyih
Copy link
Contributor Author

jingyih commented Nov 22, 2019

cc @YoyinZyc @gyuho

@jingyih jingyih changed the title Migrate cluster membership to use v3 backend Migrate cluster attributes to use v3 backend Nov 26, 2019
@gyuho
Copy link
Contributor

gyuho commented Dec 9, 2019

Think all related PRs have been merged. Can we highlight this change in CHANGELOG?

@YoyinZyc
Copy link
Contributor

YoyinZyc commented Dec 9, 2019

Think all related PRs have been merged. Can we highlight this change in CHANGELOG?

Added here #11432
Only added for cluster version since publish still keeps the old behavior.

@jingyih
Copy link
Contributor Author

jingyih commented Dec 11, 2019

Closed via #11427

@jingyih jingyih closed this as completed Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants