Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test cleanup: skipped test TestV3AuthOldRevConcurrent #13805

Closed
endocrimes opened this issue Mar 15, 2022 · 2 comments · Fixed by #13828
Closed

test cleanup: skipped test TestV3AuthOldRevConcurrent #13805

endocrimes opened this issue Mar 15, 2022 · 2 comments · Fixed by #13828

Comments

@endocrimes
Copy link
Contributor

TestV3AuthOldRevConcurrent is currently blanket skipped and the referenced issue #10408 was closed by the stalebot rather than a person or commit.

With the context from here: #10468 (comment) I think it might've been replaced with the retry interceptor here: https://github.com/etcd-io/etcd/blob/main/client/v3/retry_interceptor.go#L156-L165.

The test passes when removing the skip, which implies the behaviour was fixed (potentially by the interceptor). But I'm not really sure and would like to get deeper understanding before fixing/removing it.

cc @jingyih @mitake

@mitake
Copy link
Contributor

mitake commented Mar 19, 2022

@endocrimes Thanks for sharing it, I’ll check it.

@mitake
Copy link
Contributor

mitake commented Mar 21, 2022

@endocrimes I think it's fine to re-enable the test, thanks a lot for figuring this out. I opened #13828 could you review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants