Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: extend Hash RPC to hash by revision #8016

Closed
heyitsanthony opened this issue Jun 1, 2017 · 0 comments · Fixed by #8263
Closed

api: extend Hash RPC to hash by revision #8016

heyitsanthony opened this issue Jun 1, 2017 · 0 comments · Fixed by #8263
Assignees
Milestone

Comments

@heyitsanthony
Copy link
Contributor

The Hash RPC hashes all of boltdb. Since hash uses the state of boltdb at the time of the RPC, there must be a quiescent period across the cluster to compute hashes to avoid mismatches from incoming proposals, limiting its usefulness on typical deployments.

To support hashing etcd on a live cluster, the RPC can be extended to include a revision field:

message HashRequest {
    int64 revision = 1;
}

If revision is non-zero, Hash will hash only the keys bucket and only those keys at or below the given revision.

Related: #7125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants