Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable etcd-dump-logs tool to decode kubernetes data objects in WAL log #9631

Closed
wenjiaswe opened this issue Apr 25, 2018 · 5 comments
Closed

Comments

@wenjiaswe
Copy link
Contributor

wenjiaswe commented Apr 25, 2018

etcd-dump-logs now is a great tool for wal log analysis. However, some kubernetes data in wal log is stored in a binary storage representation (starting kubernetes 1.6+). Output from etcd-dump-logs could not reveal kubernetes object. If we could provide an option for etcd-dump-logs to decode kubernetes object data at the same time of wal log dump, it would be very helpful for kubernetes users.

@jpbetz

@xiang90
Copy link
Contributor

xiang90 commented Apr 25, 2018

it seems that this should not belong to etcd repo. Or we need to provide a generic way to hook a decoder into the wal analysis tool.

@gyuho
Copy link
Contributor

gyuho commented Apr 26, 2018

c.f. #8460

@wenjiaswe
Copy link
Contributor Author

Thanks @gyuho , #8460 is a very helpful ref.

@xiang90 I agree that we should just provide a generic way to hook a decoder into etcd-dump-logs. In this particular case, auger already provide all we need to decode k8s object. I will just refactor etcd-dump-logs so it could use user specified decoder to replace meaningless hex strings with meaningful actual decoded objects whereever feasible.

@xiang90
Copy link
Contributor

xiang90 commented May 5, 2018

@wenjiaswe Thanks for the explanation. it makes sense.

@jingyih
Copy link
Contributor

jingyih commented Sep 29, 2018

Addressed by #9790.

@jingyih jingyih closed this as completed Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants