Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/release: add sha256sum summary of release assets #11087

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Aug 28, 2019

This PR adds a new file SHA256SUM to the release assets for etcd. The file contains a list of sha2456sum for each release asset. By providing a list of sha256sums we can then validate these in various ways including tools like rget[1] with the added advantage of not requiring an isolated signing key.

[1] https://github.com/merklecounty/rget

Fixes #11086

@hexfusion hexfusion modified the milestone: etcd-v3.4 Aug 28, 2019
@hexfusion
Copy link
Contributor Author

/cc @gyuho @philips

@hexfusion
Copy link
Contributor Author

hexfusion commented Aug 28, 2019

need to fix for macOS

@philips
Copy link
Contributor

philips commented Aug 28, 2019

looks fine to me on initial glance

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@gyuho
Copy link
Contributor

gyuho commented Aug 29, 2019

@hexfusion Can we backport this to release-3.4 branch?

@gyuho gyuho merged commit af840f0 into etcd-io:master Aug 29, 2019
@gyuho
Copy link
Contributor

gyuho commented Aug 29, 2019

@hexfusion Also CHANGELOG please :)

@hexfusion hexfusion deleted the add_sum branch August 29, 2019 10:33
gyuho added a commit that referenced this pull request Aug 29, 2019
…087-upstream-release-3.4

Automated cherry pick of #11087 on release 3.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

add sha256sum file to release tooling
3 participants