etcd-e2d-test:rename e2e-arm64 file and runs it on every pull request #16912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhbnz
requested changes
Nov 11, 2023
There was a problem hiding this comment.
Thanks for working on this @mingli103 - A suggestion below about how we handle the branching 🙏🏻
.github/workflows/e2e-arm64.yaml
Outdated
| @@ -20,7 +15,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 | |||
| with: | |||
| ref: "${{ inputs.etcdBranch }}" | |||
| ref: "main" | |||
There was a problem hiding this comment.
Rather than hardcoding main I suggest we remove the with: completely for actions/checkout so we use the default behaviour of only a single commit being fetched for the ref/SHA that triggered the workflow.
This will allow us to safely backport these changes to release-3.5 branch.
jmhbnz
reviewed
Nov 11, 2023
.github/workflows/e2e-arm64.yaml
Outdated
| @@ -1,11 +1,6 @@ | |||
| --- | |||
| name: Reusable Arm64 E2E Workflow | |||
There was a problem hiding this comment.
Just noticed we should probably align this name with the existing e2e per pull request workflow which is E2E: https://github.com/etcd-io/etcd/blob/main/.github/workflows/e2e.yaml#L2
So we could make this E2E-Arm64.
jmhbnz
approved these changes
Nov 11, 2023
serathius
approved these changes
Nov 11, 2023
|
Hey @mingli103 - Can you please rebase and force push this branch? We had some flaky tests recently and if you can rebase onto latest commits from |
mingli103
force-pushed
the
test-e2e-arm64
branch
from
e7c9073 to
678c87a
Compare
Recently in etcd-io#16801 we introduced on demand github actions runners for the arm64 platform. Having on demand runner infrastructure in place means we should now have enough capacity to begin running arm64 tests for every pull request. Currently we have: .github/workflows/e2e-arm64-template.yaml - Shared template .github/workflows/e2e-arm64-nightly.yaml - Runs template against both release-3.5 and main branches nightly. Moving forward we can just rename .github/workflows/e2e-arm64-template.yaml to .github/workflows/e2e-arm64.yaml and delete the other file. We can then just make the template file a standard workflow that will run on pull request. Signed-off-by: Ming Li <mli103hawk@gmail.com>
we use the default behaviour of only a single commit being fetched for the ref/SHA that triggered the workflow. Signed-off-by: Ming Li <mli103hawk@gmail.com>
Align this name with the existing e2e per pull request workflow Signed-off-by: Ming Li <mli103hawk@gmail.com>
mingli103
force-pushed
the
test-e2e-arm64
branch
from
695353e to
1b43135
Compare
mingli103
added a commit
to mingli103/etcd
that referenced
this pull request
Nov 15, 2023
…tcd-io#16912 KubeconNA 2023 Contribfest issue etcd-io#16893 . Recently in etcd-io#16801 we introduced on demand github actions runners for the arm64 platform. Having on demand runner infrastructure in place means we should now have enough capacity to begin running arm64 tests for every pull request. Currently we have: .github/workflows/e2e-arm64-template.yaml - Shared template .github/workflows/e2e-arm64-nightly.yaml - Runs template against both release-3.5 and main branches nightly. Moving forward we can just rename .github/workflows/e2e-arm64-template.yaml to .github/workflows/e2e-arm64.yaml and delete the other file. We can then just make the template file a standard workflow that will run on pull request. Signed-off-by: Ming Li <mli103hawk@gmail.com>
serathius
approved these changes
Nov 16, 2023
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
…0 to 2.18.1 Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com> Co-authored-by: Benjamin Wang <wachao@vmware.com>
Missing binary, fixes golangci-lint command not found on prow jobs Signed-off-by: Etienne Simard <esimard@ripple.com>
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
…-action Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
…stall-golangci-lint Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
Signed-off-by: arjunmalhotra1 <am2cj@virginia.edu>
mingli103
added a commit
to mingli103/etcd
that referenced
this pull request
Nov 18, 2023
…tcd-io#16912 KubeconNA 2023 Contribfest issue etcd-io#16893 . Recently in etcd-io#16801 we introduced on demand github actions runners for the arm64 platform. Having on demand runner infrastructure in place means we should now have enough capacity to begin running arm64 tests for every pull request. Currently we have: .github/workflows/e2e-arm64-template.yaml - Shared template .github/workflows/e2e-arm64-nightly.yaml - Runs template against both release-3.5 and main branches nightly. Moving forward we can just rename .github/workflows/e2e-arm64-template.yaml to .github/workflows/e2e-arm64.yaml and delete the other file. We can then just make the template file a standard workflow that will run on pull request. Signed-off-by: Ming Li <mli103hawk@gmail.com>
|
Hey @mingli103 - It looks like this pr is rewriting history. Can you please retry the rebase so your pr only includes your single commit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KubeconNA 2023 Contribfest issue #16893 . Recently in #16801 we introduced on demand github actions runners for the arm64 platform. Having on demand runner infrastructure in place means we should now have enough capacity to begin running arm64 tests for every pull request. Currently we have:
.github/workflows/e2e-arm64-template.yaml - Shared template .github/workflows/e2e-arm64-nightly.yaml - Runs template against both release-3.5 and main branches nightly. Moving forward we can just rename .github/workflows/e2e-arm64-template.yaml to .github/workflows/e2e-arm64.yaml and delete the other file. We can then just make the template file a standard workflow that will run on pull request.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.