Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crossfi mainnet #6065

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ajimeno04
Copy link

Add crossfi network

Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your explorer does not seem EIP3091 compatible when it comes to addresses

@msvstj
Copy link
Contributor

msvstj commented Nov 13, 2024

your explorer does not seem EIP3091 compatible when it comes to addresses

Hello @ligi, thank you for your note.
We have changed the standard in .json file to match expectations, however, the team is ready to do any additional required changes.

We have also contacted the team and the addresses are accessible when they have some action or funds in blockchain, for example: https://xfiscan.com/address/0x1752105609e27d385dd9de2cf78bd48d89b6500d
or
https://xfiscan.com/address/0x1e713a08d32768c17d2ff67415aac43e46d29b55

We have updated the branch to the latest version for smooth merge in case everything is alright :)
Could we invoke PR check again?

Thank you

@ElvisKrop
Copy link
Contributor

Hello @ligi 👋
I hope you are doing well. Could you kindly take a look at this PR once again? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants