Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(derive): Warnings with metrics macro #322

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix(derive): Warnings with metrics macro #322

merged 1 commit into from
Jun 26, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jun 26, 2024

Overview

Fixes the compiler warnings for unused variables with the timer! macro in kona-derive.

@clabby clabby added K-fix Kind: fix labels Jun 26, 2024
Copy link
Collaborator Author

clabby commented Jun 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby added A-derive Area: kona-derive crate labels Jun 26, 2024
@clabby clabby requested a review from refcell June 26, 2024 20:45
@clabby clabby enabled auto-merge June 26, 2024 20:45
@clabby clabby added this pull request to the merge queue Jun 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.3%. Comparing base (1017e32) to head (3b7f88c).
Report is 1 commits behind head on main.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit f44f87f Jun 26, 2024
14 checks passed
This was referenced Jun 26, 2024
@clabby clabby deleted the cl/fix-warnings branch July 2, 2024 03:36
This was referenced Jul 8, 2024
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-fix Kind: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants