chore(common): Remove need for cursors in NativeIO
#416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the need for tracking the cursor within files in `NativeIO` by creating a bidirectional pipe rather than re-using the same files for communication. This approach is much less bug-prone, and also allows for some nice simplification within a hotpath.
clabby
added
A-common
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
clabby
force-pushed
the
cl/host-io-cleanup
branch
from
3df1934
to
c67fcd1
Compare
refcell
approved these changes
Aug 5, 2024
clabby
force-pushed
the
cl/host-io-cleanup
branch
from
c67fcd1
to
e146386
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes the need for tracking the cursor within files in
NativeIOby creating a bidirectional pipe rather than re-using the same files for communication. This approach is much less bug-prone, and also allows for some nice simplification within a hotpath.