Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ECDSAContractAccount + ProxyEOA into predeploys #605

Closed
smartcontracts opened this issue Apr 23, 2021 · 1 comment
Closed

Move ECDSAContractAccount + ProxyEOA into predeploys #605

smartcontracts opened this issue Apr 23, 2021 · 1 comment
Labels
C-chore Category: Code, docs or tooling maintenance D-good-first-issue Difficulty: A great task to get started

Comments

@smartcontracts
Copy link
Contributor

Is your feature request related to a problem? Please describe.
OVM_ECDSAContractAccount and OVM_ProxyEOA are predeployed contracts that are currently sitting in their own accounts folder. I'd like to move them into the predeploys folder instead.

Describe the solution you'd like
I'd like to move OVM_ECDSAContractAccount and OVM_ProxyEOA into the predeploy folders. I don't really see the need for a separate accounts folder, especially since these contracts are indeed predeployed.
@smartcontracts smartcontracts added A-contracts C-chore Category: Code, docs or tooling maintenance labels Apr 23, 2021
@maurelian
Copy link
Contributor

Seems reasonable to me!

@smartcontracts smartcontracts added the D-good-first-issue Difficulty: A great task to get started label May 15, 2021
@smartcontracts smartcontracts mentioned this issue Jun 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-chore Category: Code, docs or tooling maintenance D-good-first-issue Difficulty: A great task to get started
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smartcontracts @maurelian