Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Lib_RingBuffer #611

Closed
smartcontracts opened this issue Apr 23, 2021 · 1 comment
Closed

Remove Lib_RingBuffer #611

smartcontracts opened this issue Apr 23, 2021 · 1 comment
Labels
C-chore Category: Code, docs or tooling maintenance

Comments

@smartcontracts
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We're still using Lib_RingBuffer but we should really get rid of it. It adds unnecessary complexity + can be replaced by simply using a standard array. Contract here: https://github.com/ethereum-optimism/optimism/blob/master/packages/contracts/contracts/optimistic-ethereum/libraries/utils/Lib_RingBuffer.sol

Describe the solution you'd like
We should remove Lib_RingBuffer and replace its usage inside OVM_ChainStorageContainer with a simple array.
@smartcontracts smartcontracts added A-contracts C-chore Category: Code, docs or tooling maintenance labels Apr 23, 2021
@smartcontracts smartcontracts mentioned this issue May 8, 2021
Merged
@smartcontracts
Copy link
Contributor Author

Closed by #821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-chore Category: Code, docs or tooling maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smartcontracts