You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This address can be read from the OptimismPortal. We should
do that manually for all existing chains, and
update the sc-ops/add-chain tool to scrape it when a chain is added (either from chain or from the deployments artifact)
write a validation check for standard chains, that their superchain config address must match the superchain wide address
I believe it is there for the convenience of downstream applications / other users. Those apps may not wish to discover addresses on chain -- it's worse than just going over multiple files since the `SuperchainConfig` can actually vary per chain and not match the standard superchain address (we only validate standard chains are compliant).
I think the codegen here is a bit of a distraction, it will contain the same information as the individual TOML files. It is just that some of the individual TOML files are missing the SuperchainConfig address.
It sounds like the better change might be to backfill missing addresses then, and add a validation check for all chains that the in chain references resolve to the ones in the registry. Would you be in favor of this @sebastianst@mds1 ? I'll push this back to a draft PR until we can align.
This address can be read from the
OptimismPortal
. We shoulddo that manually for all existing chains, and
update the
sc-ops
/add-chain
tool to scrape it when a chain is added (either from chain or from the deployments artifact)write a validation check for standard chains, that their superchain config address must match the superchain wide address
I think the codegen here is a bit of a distraction, it will contain the same information as the individual TOML files. It is just that some of the individual TOML files are missing the
SuperchainConfig
address.It sounds like the better change might be to backfill missing addresses then, and add a validation check for all chains that the in chain references resolve to the ones in the registry. Would you be in favor of this @sebastianst @mds1 ? I'll push this back to a draft PR until we can align.
Originally posted by @geoknee in #701 (comment)
The text was updated successfully, but these errors were encountered: