Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push SuperchainConfig addresses into each chain's config toml file #765

Open
geoknee opened this issue Dec 11, 2024 · 2 comments · May be fixed by #810
Open

Push SuperchainConfig addresses into each chain's config toml file #765

geoknee opened this issue Dec 11, 2024 · 2 comments · May be fixed by #810

Comments

@geoknee
Copy link
Collaborator

geoknee commented Dec 11, 2024

This address can be read from the OptimismPortal. We should

  • do that manually for all existing chains, and

  • update the sc-ops/add-chain tool to scrape it when a chain is added (either from chain or from the deployments artifact)

  • write a validation check for standard chains, that their superchain config address must match the superchain wide address

            I believe it is there for the convenience of downstream applications / other users. Those apps may not wish to discover addresses on chain -- it's worse than just going over multiple files since the `SuperchainConfig` can actually vary per chain and not match the standard superchain address (we only validate standard chains are compliant). 
    

I think the codegen here is a bit of a distraction, it will contain the same information as the individual TOML files. It is just that some of the individual TOML files are missing the SuperchainConfig address.

It sounds like the better change might be to backfill missing addresses then, and add a validation check for all chains that the in chain references resolve to the ones in the registry. Would you be in favor of this @sebastianst @mds1 ? I'll push this back to a draft PR until we can align.

Originally posted by @geoknee in #701 (comment)

@geoknee
Copy link
Collaborator Author

geoknee commented Dec 11, 2024

This aligns with the approach of simplifying things like we plan to with #715.

We should also see the SuperchainConfig appear in the codegen'ed addreses.json file.

@geoknee
Copy link
Collaborator Author

geoknee commented Dec 11, 2024

Related problem that we should clear up:

superchain_config_addr = "0x95703e0982140D16f8ebA6d158FccEde42f04a4C"

is actually the adderess of the proxy so the name should reflect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant