Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any reason why rewards endpoints are not in the Beacon section? #337

Open
Tracked by #364
nalepae opened this issue Jul 12, 2023 · 3 comments
Open
Tracked by #364

Any reason why rewards endpoints are not in the Beacon section? #337

nalepae opened this issue Jul 12, 2023 · 3 comments

Comments

@nalepae
Copy link
Contributor

nalepae commented Jul 12, 2023

  • All endpoints in the Beacon section begin with /eth/v{1,2}/beacon/...
  • All endpoints in the Builder section begin with /eth/v1/builder/...
  • All endpoints in the Config section begin with /eth/v1/config/...
  • ...

I understand there is some exceptions for ValidatorRequiredApi and Experimental sections.

However, since all rewards endpoint are also prefixed by /eth/v1/beacon/, is there any reason why they are not stored in the Beacon section as well?

(@kevinbogner)

@nalepae nalepae changed the title Any reason why Rewards is not in Beacon section? Any reason why rewards endpoints are not in the Beacon section? Jul 12, 2023
@rolfyone
Copy link
Collaborator

Purely because it's a clean grouping... they could be in the beacon section, but is there value?

@nalepae
Copy link
Contributor Author

nalepae commented Jul 13, 2023

The value would be to have all the endpoints in any <Xxx> section beginning with /eth/v{i}/xxx/..., which is currently the case for all sections, except for the Rewards section.

(And the ValidatorRequiredApi and Experimental sections as well, but all endpoints in these two sections are duplicate of other sections)

@mcdee
Copy link
Contributor

mcdee commented Jul 13, 2023

The /beacon endpoints are meant to be those that contain beacon chain structures. Rewards are derived information, so should sit outside of this namespace.

(Also beacon endpoints are mandatory for support whereas I don't believe that rewards are, but that's secondary.)

@Falehfale Falehfale mentioned this issue Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants