Update attestation APIs to support EIP-7549 #448

mehdi-aouadi · 2024-05-24T15:13:29Z

Following the Electra containers updates:

Update the /block and /pool attestation GET APIs to handle the new Electra attestations
Add Electra.Attestation schema
Extract the AttestationData schema used by both Attestation and Electra.Attestation
Update the attester slashing API
Update the IndexedAttestation schema

Partially fixes #445
Related to #447

apis/beacon/blocks/attestations.yaml

types/attestation.yaml

types/electra/attestation.yaml

apis/beacon/blocks/attestations.yaml

nflaig · 2024-05-27T13:47:57Z

What about attestation event, should it be part of this PR?

beacon-APIs/apis/eventstream/index.yaml

Lines 64 to 68 in fb718b6

    
                       attestation: 
        
                         description: The node has received an Attestation (from P2P or API) that passes validation rules of the `beacon_attestation_{subnet_id}` topic 
        
                         value: | 
        
                           event: attestation 
        
                           data: {"aggregation_bits":"0x01", "signature":"0x1b66ac1fb663c9bc59509846d6ec05345bd908eda73e670af888da41af171505cc411d61252fb6cb3fa0017b679f8bb2305b26a285fa2737f175668d0dff91cc1b66ac1fb663c9bc59509846d6ec05345bd908eda73e670af888da41af171505", "data":{"slot":"1", "index":"1", "beacon_block_root":"0xcf8e0d4e9587369b2301d0790347320302cc0943d5a1884560367e8208d920f2", "source":{"epoch":"1", "root":"0xcf8e0d4e9587369b2301d0790347320302cc0943d5a1884560367e8208d920f2"}, "target":{"epoch":"1", "root":"0xcf8e0d4e9587369b2301d0790347320302cc0943d5a1884560367e8208d920f2"}}}

mehdi-aouadi · 2024-05-28T12:58:20Z

What about attestation event, should it be part of this PR?

beacon-APIs/apis/eventstream/index.yaml

Lines 64 to 68 in fb718b6

attestation:

description: The node has received an Attestation (from P2P or API) that passes validation rules of the `beacon_attestation_{subnet_id}` topic

value: |

event: attestation

data: {"aggregation_bits":"0x01", "signature":"0x1b66ac1fb663c9bc59509846d6ec05345bd908eda73e670af888da41af171505cc411d61252fb6cb3fa0017b679f8bb2305b26a285fa2737f175668d0dff91cc1b66ac1fb663c9bc59509846d6ec05345bd908eda73e670af888da41af171505", "data":{"slot":"1", "index":"1", "beacon_block_root":"0xcf8e0d4e9587369b2301d0790347320302cc0943d5a1884560367e8208d920f2", "source":{"epoch":"1", "root":"0xcf8e0d4e9587369b2301d0790347320302cc0943d5a1884560367e8208d920f2"}, "target":{"epoch":"1", "root":"0xcf8e0d4e9587369b2301d0790347320302cc0943d5a1884560367e8208d920f2"}}}

I considered the event stream events out of the scope of this PR. Might be addressed in a separate PR imo

nflaig

Haven't reviewed everything in detail but general approach looks good to me, let's get some feedback from others, especially in regard to having to bump everything to v2 or not

apis/beacon/blocks/attestations.v2.yaml

apis/beacon/pool/attestations.yaml

apis/beacon/pool/attester_slashings_v2.yaml

types/electra/attestation.yaml

CHANGES.md

apis/beacon/pool/attestations.v2.yaml

apis/beacon/pool/attester_slashings.v2.yaml

types/electra/attestation.yaml

rolfyone · 2024-05-30T20:36:48Z

Yep I agree with new version for interfaces given they're a new required field (breaking) and headers.
minor comment about references to /dev versions.

apis/beacon/pool/attestations.v2.yaml

apis/beacon/pool/attester_slashings.v2.yaml

apis/beacon/pool/attestations.v2.yaml

apis/beacon/pool/attester_slashings.v2.yaml

types/electra/attestation.yaml

nflaig

need to resolve conflicts since we merged #447

types/electra/attestation.yaml

apis/beacon/blocks/attestations.v2.yaml

apis/beacon/pool/attestations.v2.yaml

types/attestation_data.yaml

types/electra/attestation.yaml

beacon-node-oapi.yaml

types/electra/attestation.yaml

nflaig reviewed May 24, 2024

View reviewed changes

nflaig reviewed May 27, 2024

View reviewed changes

apis/beacon/blocks/attestations.yaml Outdated Show resolved Hide resolved

mehdi-aouadi requested a review from nflaig May 28, 2024 12:59

nflaig reviewed May 28, 2024

View reviewed changes

apis/beacon/pool/attestations.v2.yaml Show resolved Hide resolved

apis/beacon/pool/attester_slashings.v2.yaml Show resolved Hide resolved

rolfyone reviewed May 30, 2024

View reviewed changes

types/electra/attestation.yaml Outdated Show resolved Hide resolved

rolfyone reviewed May 30, 2024

View reviewed changes

types/electra/attestation.yaml Outdated Show resolved Hide resolved

rkapka reviewed Jun 5, 2024

View reviewed changes

rkapka approved these changes Jun 14, 2024

View reviewed changes

rkapka requested changes Jun 14, 2024

View reviewed changes

types/electra/attestation.yaml Show resolved Hide resolved

nflaig mentioned this pull request Jun 18, 2024

Add v2 attestation APIs to support EIP-7549 ChainSafe/lodestar#6895

Open

8 tasks

nflaig reviewed Jun 27, 2024

View reviewed changes

mehdi-aouadi added 11 commits June 27, 2024 17:53

update attestation APIs to support EIP-7549

ce9248f

fix attestations array shcema

f65f537

fix one of array item schemas

e48a7e7

use anyOf instead of oneOf

24e9251

bump attestations apis to v2

fd69e15

add change log entries

997e21b

refactoring

1245eb6

add consensus version header to POST apis parameters

f2aeebf

update spec version

e815e4f

fix typos

ea9832e

rebase master

3261557

mehdi-aouadi force-pushed the eip-7549 branch from 0da8151 to 3261557 Compare June 27, 2024 16:15

mehdi-aouadi added 3 commits June 27, 2024 18:17

update indexed attestation spec link

757e314

update changes log

ed03dfd

add new line

79c54ae

mehdi-aouadi requested review from nflaig, rkapka and rolfyone June 27, 2024 17:32

Review PR

6bc0ec8

nflaig reviewed Jun 27, 2024

View reviewed changes

beacon-node-oapi.yaml Show resolved Hide resolved

types/electra/attestation.yaml Outdated Show resolved Hide resolved

nflaig and others added 2 commits June 27, 2024 22:36

Merge branch 'master' into eip-7549

adbcc6f

fixing reviews

bb0b6ae

mehdi-aouadi requested a review from nflaig June 28, 2024 09:00

nflaig added 2 commits June 28, 2024 10:49

Fix Attestation field order

b68317e

Correct committee_bits example

9defc48

nflaig previously approved these changes Jun 28, 2024

View reviewed changes

Fix required properties ordering

f45461c

nflaig dismissed their stale review via f45461c June 28, 2024 09:56

nflaig approved these changes Jun 28, 2024

View reviewed changes

dapplion approved these changes Jun 28, 2024

View reviewed changes

realbigsean mentioned this pull request Jul 1, 2024

Beacon api + validator electra sigp/lighthouse#5744

Merged

7 tasks

rkapka approved these changes Jul 2, 2024

View reviewed changes

This was referenced Jul 3, 2024

Add the block attestations v2 API Consensys/teku#8264

Closed

Add the attestations pool v2 API Consensys/teku#8029

Closed

Add the new GetAttesterSlashing v2 API Consensys/teku#8122

Closed

nflaig merged commit 41cc574 into ethereum:master Jul 4, 2024
3 checks passed

mehdi-aouadi deleted the eip-7549 branch July 4, 2024 11:24

This was referenced Jul 5, 2024

Add the new PostAttestation v2 API Consensys/teku#8424

Closed

Add the new PostAttesterSlashing V2 API Consensys/teku#8425

Closed

Emmanuel0899 approved these changes Jul 11, 2024

View reviewed changes

This was referenced Aug 10, 2024

Release v2.6.0 nflaig/beacon-APIs#8

Merged

Release v2.6.0 nflaig/beacon-APIs#13

Merged

Release v3.0.0-alpha.0 nflaig/beacon-APIs#15

Closed

Release v3.0.0 nflaig/beacon-APIs#17

Merged

pedromiguelmiranda mentioned this pull request Sep 17, 2024

Attestation API updates for Electra status-im/nimbus-eth2#6557

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update attestation APIs to support EIP-7549 #448

Update attestation APIs to support EIP-7549 #448

mehdi-aouadi commented May 24, 2024

nflaig commented May 27, 2024

mehdi-aouadi commented May 28, 2024

nflaig left a comment

rolfyone commented May 30, 2024

nflaig left a comment

Update attestation APIs to support EIP-7549 #448

Update attestation APIs to support EIP-7549 #448

Conversation

mehdi-aouadi commented May 24, 2024

nflaig commented May 27, 2024

mehdi-aouadi commented May 28, 2024

nflaig left a comment

Choose a reason for hiding this comment

rolfyone commented May 30, 2024

nflaig left a comment

Choose a reason for hiding this comment