Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discv5: use compressed ephemeral key in handshake #135

Closed
jannikluhn opened this issue Jan 15, 2020 · 2 comments · Fixed by #157
Closed

discv5: use compressed ephemeral key in handshake #135

jannikluhn opened this issue Jan 15, 2020 · 2 comments · Fixed by #157

Comments

@jannikluhn
Copy link

It doesn't seem to be explicitly documented, but apparently we use the 64 byte uncompressed format for sending ephemeral public keys (according to the wire test vectors). In ENRs we use the 33 byte compressed format. I think this is discrepancy is unnecessarily confusing.

ENRs are already EIPed, but would it be too late already to change the wire protocol to use the compressed format?

@fjl
Copy link
Collaborator

fjl commented Jan 16, 2020

No, it's not too late to change the wire protocol. I can create a PR to change it, but we need to notify all implementers. Would be good to have a list of implementations :)

@fjl fjl changed the title DiscV5: Public Key Format discv5: use compressed ephemeral key in handshake Jan 17, 2020
@fjl fjl added this to the Discovery v5 milestone Jan 17, 2020
@fjl
Copy link
Collaborator

fjl commented Mar 9, 2020

The point compression will add a bit of extra CPU time to the handshake, need to benchmark how much.

@fjl fjl mentioned this issue Jul 29, 2020
2 tasks
@fjl fjl closed this as completed in #157 Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants