We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's pretty natural to want to supply a log topic as a 32-byte bytes value instead of a hex string.
bytes
Right now, only hex-encoded strings of 32 bytes are supported.
Add tests that 32-byte values will be accepted, like these, but with a decode_hex():
decode_hex()
eth-tester/tests/core/validation/test_inbound_validation.py
Lines 160 to 165 in 035dde2
Add tests that 31 or 33-byte values are not accepted.
Add tests that the logs are correctly found when a bytes-value is supplied to create_log_filter():
create_log_filter()
eth-tester/eth_tester/utils/backend_testing.py
Line 1145 in 2098d83
Implement any conversions needed to make ^ pass.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
What was wrong?
It's pretty natural to want to supply a log topic as a 32-byte
bytes
value instead of a hex string.Right now, only hex-encoded strings of 32 bytes are supported.
How can it be fixed?
Add tests that 32-byte values will be accepted, like these, but with a
decode_hex()
:eth-tester/tests/core/validation/test_inbound_validation.py
Lines 160 to 165 in 035dde2
Add tests that 31 or 33-byte values are not accepted.
Add tests that the logs are correctly found when a bytes-value is supplied to
create_log_filter()
:eth-tester/eth_tester/utils/backend_testing.py
Line 1145 in 2098d83
Implement any conversions needed to make ^ pass.
The text was updated successfully, but these errors were encountered: