Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete py.typed file, remove from package info #292

Merged
merged 1 commit into from
Apr 22, 2024
Merged

delete py.typed file, remove from package info #292

merged 1 commit into from
Apr 22, 2024

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Apr 19, 2024 •
edited
Loading

What was wrong?

A py.typed file snuck into an un-typed lib. Removing.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

image

@pacrob pacrob requested review from reedsa and kclowes April 19, 2024 21:47
kclowes
kclowes approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pacrob pacrob merged commit fd0d241 into ethereum:main Apr 22, 2024
24 checks passed
@pacrob pacrob deleted the drop-py-typed-file branch April 22, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

@reedsa reedsa Awaiting requested review from reedsa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pacrob @kclowes