-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add POST /eth/v1/validator/sync_committee_subscriptions #136
add POST /eth/v1/validator/sync_committee_subscriptions #136
Conversation
https://hackmd.io/@QYHAVYiHRg65pdI_CEm7Eg/syncommitteeapi#POST-ethv1validatorsync_committee_subscriptions notable differences: - using committee subnets to subscribe in the body, otherwise the VC needs to cache and recalculate more. also the subnets is an array so that multiple can be subscribed to per entry - is_aggregator is not really needed in this instance as far as we can tell, and potentially won't be known at the time of making the subscription. - added `until_epoch` so that the BN can unsubscribe based on this request.
@rolfyone Could you explain in more detail why it's not needed? |
The beacon node is required to subscribe to the subnet regardless of whether the validator is an aggregator or not, so there's no change in beacon node behaviour. That provides the stable backbone of peers on the subnet. Also given sync committee periods are 256 epochs long (might have even changed to 512?) a validator would have to sign 256*32 = 8192 slots to check if it was an aggregator and it almost always will be at some point during the sync committee period. |
@rolfyone |
The intent was that you'd unsubscribe once that epoch was past, so if it's 'untilEpoch' 20, you unsubscribe at the first slot of 21. |
https://hackmd.io/@QYHAVYiHRg65pdI_CEm7Eg/syncommitteeapi#POST-ethv1validatorsync_committee_subscriptions
notable differences:
sync_committee_index
became an array: sync_committee_indices, as multiple subnets per validator is possible.is_aggregator
is not really needed in this instance as far as we can tell, and potentially won't be known at the time of making the subscription.added
until_epoch
so that the BN can unsubscribe based on this request.