Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Hex.toHexString in logging, toString etc to safer alternative in Tests #1081

Closed
kishansagathiya opened this issue May 23, 2018 · 1 comment

Comments

@kishansagathiya
Copy link
Contributor

Whatever was done in #1069, We might require a similar exercise in tests as well

@zilm13
Copy link
Collaborator

zilm13 commented May 23, 2018

@kishansagathiya I don't think it's required. We need it in app, because complete logging is useful to find strange bugs when you have not reproducible report + on some logging levels new errors occur due to lack of safety in logging. When strange values appears in test, it's reproducible and it's a sign that test should be fixed.

@zilm13 zilm13 closed this as completed May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants