Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused line of code? #1263

Open
kant111 opened this issue Feb 20, 2019 · 2 comments
Open

unused line of code? #1263

kant111 opened this issue Feb 20, 2019 · 2 comments

Comments

@kant111
Copy link

kant111 commented Feb 20, 2019

I was trying to see if Block Miner runs an independent separate thread with a time period or is there something that triggers a mining? Meanwhile, I found the code below where I think it is unused unless there is some spring framework magic that I am unaware of?

https://github.com/ethereum/ethereumj/blob/develop/ethereumj-core/src/main/java/org/ethereum/mine/BlockMiner.java#L53

@mkalinin
Copy link
Contributor

Yep, as far as I can see this executor is not used in any part of the codebase.

@kant111
Copy link
Author

kant111 commented Feb 21, 2019

@mkalinin should I just remove this line and send a PR? Also can you please point where the independent thread for mining gets created? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants