Updated solc to v0.8.0. #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-r-a-n-t
force-pushed
the
solc-update
branch
from
cf8f435
to
799ac5e
Compare
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 77.93% 77.93%
=======================================
Files 45 45
Lines 3300 3300
=======================================
Hits 2572 2572
Misses 728 728 Continue to review full report at Codecov.
|
g-r-a-n-t
force-pushed
the
solc-update
branch
2 times, most recently
from
6fe3a55
to
ac6d49a
Compare
|
looks like I need to get g++ 0.8 to install |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We were using an older version of solc for Yul compilation.
How was it fixed?
Went into solc-rust and updated the solidity submodule. There are still some things that I'd like to look into in solc-rust before opening a PR in that repo, so we're just using my personal fork for now.
Surprisingly, the solc-backend feature of the Fe compiler still works fine. I thought there would be atleast a couple breaking changes in libyul.
To-Do
OPTIONAL: Update Spec if applicable
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history