Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for my_val.abi_encode() and my_val.abi_encode_packed() #189

Closed
g-r-a-n-t opened this issue Jan 15, 2021 · 1 comment
Closed

Support for my_val.abi_encode() and my_val.abi_encode_packed() #189

g-r-a-n-t opened this issue Jan 15, 2021 · 1 comment
Labels
comp: compiler prio: P2 required type: feature
Milestone
Uniswap Demo

Comments

@g-r-a-n-t
Copy link
Member

g-r-a-n-t commented Jan 15, 2021 •
edited
Loading

What is wrong?

Users cannot encode values.

How can it be fixed

We should support the attribute functions abi_encode_packed and abi_encode, which would return bytes.

The size of these bytes might be a bit tricky, since we don't support dynamically sized byte arrays.
@g-r-a-n-t g-r-a-n-t added this to the Uniswap Demo milestone Jan 15, 2021
@g-r-a-n-t g-r-a-n-t changed the title Support for my_val.abiEncode and my_val.abiEncodePacked Support for my_val.abi_encode() and my_val.abi_encode_packed() Feb 1, 2021
@g-r-a-n-t g-r-a-n-t mentioned this issue Feb 20, 2021
Merged
@g-r-a-n-t
Copy link
Member Author

abi packed stuff can now be found in #281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: compiler prio: P2 required type: feature
Projects
None yet
Milestone
Uniswap Demo
Development

No branches or pull requests
1 participant
@g-r-a-n-t