-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile multiple contracts in single module. #197
Conversation
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
- Coverage 77.96% 77.50% -0.47%
==========================================
Files 45 47 +2
Lines 3300 3308 +8
==========================================
- Hits 2573 2564 -9
- Misses 727 744 +17
Continue to review full report at Codecov.
|
28f86a9
to
77b96c9
Compare
77b96c9
to
3a07506
Compare
3a07506
to
dc8b5c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One question I have is whether this removes support for generating YUL code when the YUL code is faulty which would be a bit sad since I find it quite helpful during development.
E.g. with the current compiler one can compile fe foo.fe --emit yul
even if fe foo.fe
wouldn't work because the yul -> binary compilation errors. This is helpful to generate and inspect the faulty YUL code that leads to the compilation failure.
dc8b5c4
to
96c5a10
Compare
What was wrong?
We were only able to compile the first contract in a module.
How was it fixed?
To-Do
OPTIONAL: Update Spec if applicable
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history