Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with string literals and add support for string casts #201

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Fix bug with string literals and add support for string casts #201

merged 2 commits into from
Jan 22, 2021

Conversation

cburgdorf
Copy link
Collaborator

@cburgdorf cburgdorf commented Jan 21, 2021 •
edited
Loading

What was wrong?

  1. There was a bug if the same string literal was used multiple times
  2. We did not have support for string casts yet (e.g. string100("foo")

How was it fixed?

  1. Converted Vec<String> to HashSet<String>
  2. Refactored part that recognize string types into a reusable TryFrom
  3. Recognize stringxxx type constructors based on the TryFrom
  4. Map string type casts to the altered expression.

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@cburgdorf cburgdorf merged commit e2807d1 into ethereum:master Jan 22, 2021
@cburgdorf cburgdorf mentioned this pull request Jan 22, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-r-a-n-t g-r-a-n-t g-r-a-n-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cburgdorf @g-r-a-n-t