Ensure event emits are type checked #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
force-pushed
the
christoph/fix/event_calls
branch
2 times, most recently
from
6e83637
to
d2fcc99
Compare
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
+ Coverage 77.51% 77.73% +0.21%
==========================================
Files 46 46
Lines 3322 3323 +1
==========================================
+ Hits 2575 2583 +8
+ Misses 747 740 -7
Continue to review full report at Codecov.
|
cburgdorf
commented
Jan 22, 2021
| @@ -9,7 +9,7 @@ contract Foo: | |||
| s5: string100 | |||
|
|
|||
| pub def __init__(s1: string42, a: address, s2: string26, u: u256, s3: string100): | |||
| emit MyEvent(s2, u, s1, s3, a, "static string", "foo") | |||
| emit MyEvent(s2, u, s1, s3, a, "static string", string100("foo")) | |||
There was a problem hiding this comment.
This came to my attention after I merged #201 so it sparked this PR to tighten our type checks.
g-r-a-n-t
approved these changes
Jan 23, 2021
g-r-a-n-t
reviewed
Jan 23, 2021
| contract Foo: | ||
| event MyEvent: | ||
| val_1: string100 | ||
| val_2: u8 |
There was a problem hiding this comment.
for sanity it might be good to mark one of these as indexed
cburgdorf
force-pushed
the
christoph/fix/event_calls
branch
from
d2fcc99
to
afb812a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
On master, the following would not raise an error even though it should:
How was it fixed?
Basically reuse the
call_argthat is defined inexpressionand a little bit of refactoring the event to expose all field types.To-Do
OPTIONAL: Update Spec if applicable
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history