Support updating struct fields in storage #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
force-pushed
the
christoph/feat/struct_storage
branch
from
1b6ed53
to
35bd4f9
Compare
cburgdorf
commented
Feb 13, 2021
| let ptr = get_full_signature(nonce.to_string().as_bytes()); | ||
| let ptr = literal_expression! { (ptr) }; | ||
| let offset = literal_expression! { (offset) }; | ||
| expression! { (add([ptr], [offset])) } |
There was a problem hiding this comment.
@g-r-a-n-t Not sure if this is still the right thing to do after your recent findings about how to deal with storage.
But if it is, we should probably calculate the ptr manually to get rid of the add(ptr, offset). I thought that this is something that the optimizer would do for us but I ran with --optimize and it isn't optimizing the add away.
There was a problem hiding this comment.
👍 I will create an issue to track this optimization though
cburgdorf
changed the title
g-r-a-n-t
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We did not support updating individual struct fields in storage (e.g.
self.my_struct.some_field = 1)How was it fixed?
ptr_of_storage_struct + 32 * field_indexTo-Do
OPTIONAL: Update Spec if applicable
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history