Implement keccak256 as builtin method #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
+ Coverage 93.91% 93.99% +0.08%
==========================================
Files 54 54
Lines 3744 3761 +17
==========================================
+ Hits 3516 3535 +19
+ Misses 228 226 -2
Continue to review full report at Codecov.
|
cburgdorf
force-pushed
the
christoph/feat/keccak256
branch
2 times, most recently
from
efcbb55
to
65e5530
Compare
cburgdorf
commented
Feb 16, 2021
cburgdorf
force-pushed
the
christoph/feat/keccak256
branch
3 times, most recently
from
e1adfa5
to
b1a5c80
Compare
g-r-a-n-t
approved these changes
Feb 17, 2021
| @@ -67,8 +71,7 @@ fn move_expression( | |||
| from: Location, | |||
| to: Location, | |||
| ) -> Result<yul::Expression, CompileError> { | |||
| let typ = | |||
| FixedSize::try_from(typ).map_err(|_| CompileError::static_str("invalid attributes"))?; | |||
| let typ = to_fixed_size(&typ)?; | |||
There was a problem hiding this comment.
I think we should keep the original line with an expect instead of map_err, so we crash in this situation. All the results should be removed in this module.
cburgdorf
force-pushed
the
christoph/feat/keccak256
branch
from
b1a5c80
to
f5f2afe
Compare
cburgdorf
force-pushed
the
christoph/feat/keccak256
branch
from
f5f2afe
to
b56c960
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
As discussed in #188. Fe needs to expose the
keccak256hash function to be usable from user code.How was it fixed?
keccak256as a global functionbytes[n]parameterget_keccak256methodkeccak256can not be called with arrays of other typeskeccak256functionTo-Do