Expose abi encoding #266
Merged
Expose abi encoding #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-r-a-n-t
commented
Feb 24, 2021
g-r-a-n-t
commented
Feb 24, 2021
| Struct, | ||
| }; | ||
| use yultsur::*; | ||
|
|
||
| #[test] | ||
| fn test_new() { | ||
| let mut val = Struct::new("Foo"); | ||
| val.add_field("bar", &Base::Bool); | ||
| val.add_field("bar2", &Base::Bool); | ||
| val.add_field("bar", &FixedSize::Base(Base::Bool)); |
There was a problem hiding this comment.
we could add functions like FixedSize::bool() to make tests cleaner
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 93.94% 93.73% -0.21%
==========================================
Files 54 54
Lines 3798 3816 +18
==========================================
+ Hits 3568 3577 +9
- Misses 230 239 +9
Continue to review full report at Codecov.
|
g-r-a-n-t
force-pushed
the
expose-abi-encoding
branch
from
c07d8e9
to
d67da4a
Compare
g-r-a-n-t
force-pushed
the
expose-abi-encoding
branch
from
d67da4a
to
c1b5404
Compare
cburgdorf
reviewed
Feb 24, 2021
| // less than 32 bytes. So, when we get the pointer to the value of a struct | ||
| // field, we must take into consideration the left-padding. The left-padding is | ||
| // equal to the difference between the value's size and 32 bytes, so we end up | ||
| // adding the word offset and the byte offset. |
cburgdorf
reviewed
Feb 24, 2021
| 0, 0, 0, 0, 1, 244, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, | ||
| 0, 0, 0, 0, 0, 0, 0, 0, 0, 20, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, | ||
| 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, | ||
| ]; |
There was a problem hiding this comment.
I like how the nitty gritty details exposed by this test!
cburgdorf
reviewed
Feb 24, 2021
| @@ -303,3 +309,58 @@ fn test_runtime_set_zero() { | |||
| ); | |||
| }) | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_runtime_house_struct() { | |||
There was a problem hiding this comment.
This is such a cool test 👏
cburgdorf
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The main goal of this PR is to implement ABI encoding for structs and expose it the user via a builtin attribute function
abi_encode().How was it fixed?
AbiEncodingtrait for structs. This was quite easy since structs are already encoded following the ABI standard.abi_encode()attribute function for structs.There were a few other things that I ran into and fixed/changed.
field_index * 32 + (32 - field_size)instead offield_index * 32, which fixed a bug I was seeing.dimensiontosize. This should be correct terminology.To-Do
Update Spec if applicable
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history