Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for self.address and bool operations #270

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

g-r-a-n-t
Copy link
Member

@g-r-a-n-t g-r-a-n-t commented Feb 26, 2021

What was wrong?

We didn't support the two small features mentioned above. They are both needed for the Uniswap demo.

How was it fixed?

  • analyzing the expressions
  • mapping the expressions
  • testing

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@g-r-a-n-t g-r-a-n-t force-pushed the small-features branch 2 times, most recently from fbac494 to aa5ef07 Compare February 26, 2021 01:38
@codecov-io
Copy link

codecov-io commented Feb 26, 2021

Codecov Report

Merging #270 (81695e0) into master (f978266) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   93.82%   93.84%   +0.01%     
==========================================
  Files          56       56              
  Lines        3922     3932      +10     
==========================================
+ Hits         3680     3690      +10     
  Misses        242      242              
Impacted Files Coverage Δ
analyzer/src/traversal/expressions.rs 93.05% <100.00%> (+0.14%) ⬆️
compiler/src/yul/mappers/expressions.rs 97.24% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f978266...aa5ef07. Read the comment docs.

@g-r-a-n-t g-r-a-n-t merged commit c04a7f4 into ethereum:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants