Add overflow/underflow checks for multiplicatons #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
commented
Feb 26, 2021
cburgdorf
commented
Feb 26, 2021
cburgdorf
commented
Feb 26, 2021
g-r-a-n-t
reviewed
Mar 2, 2021
cburgdorf
force-pushed
the
christoph/feat/checked_mul
branch
from
25d1caa
to
f0a4f8b
Compare
cburgdorf
commented
Mar 2, 2021
cburgdorf
force-pushed
the
christoph/feat/checked_mul
branch
from
f0a4f8b
to
eecaa14
Compare
cburgdorf
changed the title
|
@g-r-a-n-t I skipped the failing |
g-r-a-n-t
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We do not yet perform overflow/underflow checks for multiplications.
How was it fixed?
Pretty straight forward based on the previous implementations for add and sub. Except for that pesty rusty-evm bug that I created an issue for: #285