Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builtin address attribute on contract types #287

Open
g-r-a-n-t opened this issue Mar 3, 2021 · 0 comments
Open

Builtin address attribute on contract types #287

g-r-a-n-t opened this issue Mar 3, 2021 · 0 comments
Milestone
Uniswap Demo

Comments

@g-r-a-n-t
Copy link
Member

We talked about that instead of obtaining the address via address(token0) we could also obtain it via token.address. I think that would be inline with self.address, too. address would be a reserved word in the context of a contract properties. Since the ABI only defines functions it would still be allowed for a contract to implement an address() function though. We should probably create an issue and put a comment in for that, too.

Originally posted by @cburgdorf in #179 (comment)
@g-r-a-n-t g-r-a-n-t added this to the Uniswap Demo milestone Mar 3, 2021
@g-r-a-n-t g-r-a-n-t changed the title Buildtin address attribute on contract types Builtin address attribute on contract types Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Uniswap Demo
Development

No branches or pull requests
1 participant
@g-r-a-n-t