Implement msg.sig #311
Implement msg.sig #311
Conversation
There was a problem hiding this comment.
Thanks for the PR. Looks good. Just a tiny nitpick about the casing. Also do you mind creating a file 311.feature.md in https://github.com/ethereum/fe/tree/master/newsfragments with the content being something like:
Support for
msg.sigto read the function identifier
This is to ensure the feature gets included in the next release notes.
| @@ -0,0 +1,5 @@ | |||
| contract Foo: | |||
| pub def bar() -> bytes[32]: | |||
| msgSig: bytes[32] | |||
There was a problem hiding this comment.
The idiomatic way to write Fe code is with snake_case. Please change msgSig to msg_sig.
compiler/tests/utils.rs
Outdated
| @@ -316,6 +317,19 @@ pub fn bytes_token(s: &str) -> ethabi::Token { | |||
| ethabi::Token::FixedBytes(ethabi::FixedBytes::from(s)) | |||
| } | |||
|
|
|||
| #[allow(dead_code)] | |||
| pub fn bytes32(s: &str) -> Vec<u8> { | |||
| H256::from_str(s) | |||
There was a problem hiding this comment.
Just pointing out that we try to not use single letter variable names such as s. That said, this file violates that rule numerous times and we don't need to fix that in this PR :)
|
Addressed all comments. |
|
Awesome! Landed 🎉 |
Fixes #278
To-Do
OPTIONAL: Update Spec if applicable
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history