Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement checks for modulo arithmetic #312

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

cburgdorf
Copy link
Collaborator

@cburgdorf cburgdorf commented Mar 16, 2021

What was wrong?

Modulo arithmetic isn't checked yet.

How was it fixed?

Pretty straight forward based on how the previous checks were implemented.

@cburgdorf cburgdorf force-pushed the christoph/feat/checked_mod branch 2 times, most recently from 9e08253 to 24135bb Compare March 16, 2021 11:56
@cburgdorf cburgdorf marked this pull request as draft March 16, 2021 12:05
@cburgdorf cburgdorf marked this pull request as ready for review March 16, 2021 13:46
@codecov-io
Copy link

Codecov Report

Merging #312 (364ec10) into master (30efce0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   93.74%   93.76%   +0.01%     
==========================================
  Files          56       56              
  Lines        4012     4024      +12     
==========================================
+ Hits         3761     3773      +12     
  Misses        251      251              
Impacted Files Coverage Δ
compiler/src/yul/mappers/assignments.rs 97.82% <100.00%> (ø)
compiler/src/yul/mappers/expressions.rs 96.57% <100.00%> (ø)
compiler/src/yul/names.rs 100.00% <100.00%> (ø)
compiler/src/yul/runtime/functions/math.rs 95.00% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30efce0...364ec10. Read the comment docs.

@cburgdorf cburgdorf merged commit e017cad into ethereum:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants