Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ContextHarness #318

Closed
g-r-a-n-t opened this issue Mar 19, 2021 · 1 comment
Closed

Fix ContextHarness #318

g-r-a-n-t opened this issue Mar 19, 2021 · 1 comment
Labels
type: tests

Comments

@g-r-a-n-t
Copy link
Member

What is wrong?

from #315

ContextHarness was broken by this change, since it relies on adding attributes to the context via the span. I've disabled this with the feature fix-context-harness and will create an issue to fix this (if merging this with the failing tests sounds ok).

How can it be fixed

This isn't very straight forward.
@g-r-a-n-t g-r-a-n-t mentioned this issue Mar 19, 2021
Closed
3 tasks
@sbillig
Copy link
Collaborator

sbillig commented Oct 22, 2021

Defunct

@sbillig sbillig closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lowering pass and tuple support g-r-a-n-t/fe
2 participants
@sbillig @g-r-a-n-t