Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly reject calling an undefined function on an external contract #324

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Properly reject calling an undefined function on an external contract #324

merged 2 commits into from
Mar 22, 2021

Conversation

cburgdorf
Copy link
Collaborator

@cburgdorf cburgdorf commented Mar 22, 2021 •
edited
Loading

What was wrong?

Calling an undefined function on an external contract isn't yet properly rejected. See #237

How was it fixed?

  • Return SemanticError::undefined_value() in case the function does not exist on the external contract.
  • Added a few more tests around undefined functions

@cburgdorf cburgdorf force-pushed the christoph/fix/call_undefined_function branch from 8cdb329 to 6aff4c1 Compare March 22, 2021 12:03
@cburgdorf cburgdorf merged commit 3a7fa34 into ethereum:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-r-a-n-t g-r-a-n-t g-r-a-n-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cburgdorf @g-r-a-n-t