Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary operation checks. #347

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Binary operation checks. #347

merged 1 commit into from
Mar 31, 2021

Conversation

g-r-a-n-t
Copy link
Member

@g-r-a-n-t g-r-a-n-t commented Mar 30, 2021 •
edited
Loading

What was wrong?

fixes #345

How was it fixed?

  • added a checking method for binary operations to the operations module
  • used this function to check binary operations and augmented assignments
  • added more compiler error tests

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@g-r-a-n-t g-r-a-n-t marked this pull request as draft March 30, 2021 17:05
@g-r-a-n-t g-r-a-n-t force-pushed the bin-op-checks branch 2 times, most recently from bb90622 to efdf091 Compare March 30, 2021 20:15
@g-r-a-n-t g-r-a-n-t marked this pull request as ready for review March 31, 2021 19:41
@g-r-a-n-t g-r-a-n-t requested a review from sbillig March 31, 2021 19:41
@sbillig sbillig merged commit b0d8ccd into ethereum:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cburgdorf cburgdorf cburgdorf left review comments

@sbillig sbillig sbillig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tighter checking on binary operations.
3 participants
@g-r-a-n-t @sbillig @cburgdorf