Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__init__ must be pub #435

Merged
merged 1 commit into from
Jun 1, 2021
Merged

__init__ must be pub #435

merged 1 commit into from
Jun 1, 2021

Conversation

g-r-a-n-t
Copy link
Member

@g-r-a-n-t g-r-a-n-t commented Jun 1, 2021

What was wrong?

closes #353

See #353 (comment)

How was it fixed?

Throw a compiler error if __init__ is not public.

My thinking is that __init__ should either always be public or not public. If there are good reasons to go with always not pub, then I can modify this PR to do the opposite.

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@codecov-commenter
Copy link

Codecov Report

Merging #435 (5859273) into master (60cf4f1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   86.10%   86.13%   +0.02%     
==========================================
  Files          71       71              
  Lines        4729     4738       +9     
==========================================
+ Hits         4072     4081       +9     
  Misses        657      657              
Impacted Files Coverage Δ
analyzer/src/traversal/functions.rs 94.26% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60cf4f1...5859273. Read the comment docs.

Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@g-r-a-n-t g-r-a-n-t merged commit 9686ec3 into ethereum:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yul compilation failed: DeclarationError: Function not found.
3 participants