Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user-facing todos and unimplementeds #436

Closed
g-r-a-n-t opened this issue Jun 1, 2021 · 3 comments · Fixed by #437
Closed

Remove user-facing todos and unimplementeds #436

g-r-a-n-t opened this issue Jun 1, 2021 · 3 comments · Fixed by #437
Labels
comp: analyzer Everything that involves the analyzer pass type: chore

Comments

@g-r-a-n-t
Copy link
Member

What is wrong?

The compiler will crash during analysis of features that are not yet implemented. For this reason, we have been filtering out crashes that display the text "not implemented" or "not yet implemented" when fuzzing. This would be fine if we didn't also use these panic messages in later stages of compilation, but we are, and it's likely that we've been filtering out meaningful crashes.

How can it be fixed

  • replace all justifiable todos and unimplementeds with graceful analyzer errors
  • let agroce know that any panic is considered a bug
@g-r-a-n-t
Copy link
Member Author

filtering out certain panics is no longer necessary @agroce

@agroce
Copy link

agroce commented Jun 3, 2021

Ok! It may take me a day or two to restart the fuzzer instances with the latest source, but I'll put them on the "no holds barred" task before too long.

@agroce
Copy link

agroce commented Jun 11, 2021

Hmm. On latest github, I get:

target/debug/fe tests/src/lowering/fixtures/nested_tuple.fe
thread 'main' panicked at 'not yet implemented', compiler/src/lowering/names.rs:38:32
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

You've hit an internal compiler error. This is a bug in the Fe compiler.
Fe is still under heavy development, and isn't yet ready for production use.

If you would, please report this bug at the following URL:
  https://github.com/ethereum/fe/issues/new
Aborted

so there are still "not implemented"s -- I assume bug reportable, though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: analyzer Everything that involves the analyzer pass type: chore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants